> On Oct. 16, 2018, 3:25 p.m., Sergio Pena wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 3460-3462 (patched) > > <https://reviews.apache.org/r/68958/diff/4/?file=2096777#file2096777line3460> > > > > Could you display the progress in %? Use the objectsPersistedCount for > > that. > > > > Btw, sorry I told you about using HMS snapshot message, but this method > > references to that as 'Full paths', so it would be good to make that change > > to be consistent.
I think counts are better than percentages as they are accurate while percentages will have to be rounded up or down. Also percentages can be easily calculated - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68958/#review209627 ----------------------------------------------------------- On Oct. 12, 2018, 2 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68958/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2018, 2 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2419 > https://issues.apache.org/jira/browse/SENTRY-2419 > > > Repository: sentry > > > Description > ------- > > Process of persisting the snapshot might take longer based on the snapshot > size. It would be helpfull to to be able to understand where the sentry > sentry stands in the process of persisting. > > > > Adding a Metric for this will be helpfull in debugging. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java > d34340cd6 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/HMSFollower.java > b6dca7aa8 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 7a736ca96 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java > 3a68eb6bf > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java > 059621a68 > > > Diff: https://reviews.apache.org/r/68958/diff/4/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
