----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68926/#review209866 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java Lines 311 (patched) <https://reviews.apache.org/r/68926/#comment294472> can you change the name of p1 and p2 to be more meaningful names? For example, p1 -> grantorPrivilege, the privielge that grantor has p2 -> privilegeToGrant, the privilege that grantor is going to grant to another role or user. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java Lines 356 (patched) <https://reviews.apache.org/r/68926/#comment294473> is it possible p2.action is null? If so, need to check that first before comparing. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java Lines 454 (patched) <https://reviews.apache.org/r/68926/#comment294474> change comment to be clear because this is to revoke privilege sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java Lines 584 (patched) <https://reviews.apache.org/r/68926/#comment294475> do you need to add such functions for user as well? like alterSentryUserGrantPrivileges - Na Li On Oct. 20, 2018, 7:06 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68926/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2018, 7:06 p.m.) > > > Review request for sentry and kalyan kumar kalvagadda. > > > Bugs: SENTRY-2372 > https://issues.apache.org/jira/browse/SENTRY-2372 > > > Repository: sentry > > > Description > ------- > > Make the grant option check on the SentryPolicyStoreProcessor so that it gets > the group information from it. The SentryStore has the new method to check > the grant option in the DB only. > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryUtils.java > b225af0bc4e8c472e2ee17677a74525b882e214c > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryPlugin.java > b8f5ce7dbc8cd2dd6317f02cc09a225ef460acf4 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java > 709434c388689b63d5db7d71cd6cc47952d647bf > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java > eba40d2ebd9778ddf74df0d35ad8b22500717f73 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > b387a22e40b8958395e1c12af12272b89a778726 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java > 6217719b8cf0c120b47a1612f6b3f0bbba98f724 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessorTestUtils.java > PRE-CREATION > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java > 16ff79e2e4258c20a46ffcf162872b5b20d97aba > > > Diff: https://reviews.apache.org/r/68926/diff/4/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
