> On Oct. 23, 2018, 3:44 p.m., Arjun Mishra wrote: > > Let me know what you think about this. I think we could minimize the change > > set by keeping changes to the core methods? alterSentryRevokePrivilegeCore > > and alterSentryGrantPrivilegeCore? > > For example there are methods like dropOrRenamePrivilegeForAllEntities, and > > importRolePrivilegeMapping that don't have a trim and lower change to it
agree. It is cleaner and can make sure we process input name correctly. I will make change accordingly - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69122/#review209923 ----------------------------------------------------------- On Oct. 22, 2018, 10:04 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69122/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2018, 10:04 p.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Sergio > Pena. > > > Bugs: sentry-2432 > https://issues.apache.org/jira/browse/sentry-2432 > > > Repository: sentry > > > Description > ------- > > Keep user name case when saving into sentry DB and fetching privileges for > that user. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/QueryParamBuilder.java > f29c455 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > b387a22 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 4a9afe3 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestOwnerPrivileges.java > d3294f4 > > > Diff: https://reviews.apache.org/r/69122/diff/1/ > > > Testing > ------- > > add new test case to check authorization based on user name case > > > Thanks, > > Na Li > >
