----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69204/#review210171 -----------------------------------------------------------
Fix it, then Ship it! With this change you are able to levarage the batching capability of datanucelus which makes it faster. Please fix them and ship it. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Line 734 (original), 732 (patched) <https://reviews.apache.org/r/69204/#comment294797> Could you please add a comment for this method explaning it. It will make code readable. It was missing before. It's good to add them when we get a chance. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Line 1002 (original), 993 (patched) <https://reviews.apache.org/r/69204/#comment294798> Could you please add a comment for this method explaning it. It will make code readable. It was missing before. It's good to add them when we get a chance. - kalyan kumar kalvagadda On Oct. 29, 2018, 9:35 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69204/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2018, 9:35 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2437 > https://issues.apache.org/jira/browse/SENTRY-2437 > > > Repository: sentry > > > Description > ------- > > Currently sentry creates a transaction for each TSentryPrivilege object it > needs to grant. If the list of privileges is very large creating a single > transaction for each significantly affects performance. This is particularly > impactful for tables with large columns and if a user grants privileges to > many of those columns > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 01b363479 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java > 97407fff5 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java > 1d87b0b66 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > f2f38a38f > > > Diff: https://reviews.apache.org/r/69204/diff/2/ > > > Testing > ------- > > $ mvn -f sentry-service/sentry-service-server/pom.xml test > -Dtest=TestSentryStore > $ mvn -f sentry-service/sentry-service-server/pom.xml test > -Dtest=TestHMSFollowerSentryStoreIntegration > > > Thanks, > > Arjun Mishra > >
