----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69087/#review210254 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 3304-3305 (original), 3311 (patched) <https://reviews.apache.org/r/69087/#comment294885> What changed here? sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 3327 (patched) <https://reviews.apache.org/r/69087/#comment294886> Why can't the MPath used here? - Sergio Pena On Oct. 31, 2018, 11:28 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69087/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2018, 11:28 p.m.) > > > Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2249 > https://issues.apache.org/jira/browse/SENTRY-2249 > > > Repository: sentry > > > Description > ------- > > Currently each entry in full snapshot of HMS is persisted one entry at a > time. Instead it could be optimized by persisting the path entries in > batches. DB operations are expensive, reducing the number of database > operations and around trip time will help. This would decrease the time to > persist the snapshot in to database significantly. > > Size of the batch could be configurable. > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryConstants.java > d8c1061d36ed0b92116f0b2dd5ec820ccb166818 > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/service/common/ServiceConstants.java > 092060c450c6a906850630cb10454737157af5fe > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MAuthzPathsMapping.java > c51f25a0393b482814afcd3b7a19e547b689ac6e > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MPath.java > b0eaff2120a80685da07c65a7706edf2be62ee01 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MPathToPersist.java > PRE-CREATION > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 20ec0deab6b97065cfe99beea3d14a6c7268aac3 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 33c40613a05f7c7fde314af6aba6b269bf6ffaae > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 66db6ae9a436b9728fb3c2ebdd21167ef042f937 > > > Diff: https://reviews.apache.org/r/69087/diff/3/ > > > Testing > ------- > > Made sure all the unit tests passed. > > > Thanks, > > kalyan kumar kalvagadda > >
