----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69260/#review210353 -----------------------------------------------------------
Can you add code in unit test to verify the path is removed? For example, there is no MPath entries whose foreign key is null or the delected authorizable entry ID. - Na Li On Nov. 6, 2018, 4:59 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69260/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2018, 4:59 p.m.) > > > Review request for sentry, Arjun Mishra, Na Li, and Sergio Pena. > > > Bugs: SENTRY-2441 > https://issues.apache.org/jira/browse/SENTRY-2441 > > > Repository: sentry > > > Description > ------- > > When MAuthzPathsMapping is deleted all associated MPaths should be deleted > automatically as MPaths are directly associated to MAuthzPathsMapping. > > > > Currently when entries in MAuthzPathsMapping are deleted the FK in MPaths is > set to NULL and the entries are left. These elements are slate are not not > used and will never be cleaned. > > > > > > Instead MPaths should be removed automatically associated MAuthzPathsMapping > entries are deleted. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 20ec0deab6b97065cfe99beea3d14a6c7268aac3 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 33c40613a05f7c7fde314af6aba6b269bf6ffaae > > > Diff: https://reviews.apache.org/r/69260/diff/1/ > > > Testing > ------- > > Made sure that all the existing tests pass. > > > Thanks, > > kalyan kumar kalvagadda > >
