> On Dec. 7, 2018, 7:40 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 3932 (patched) > > <https://reviews.apache.org/r/69353/diff/2/?file=2112512#file2112512line3932> > > > > If column name is not null, should add that in filter
I added this API as part og export functionality which did not need column privileges. That is why i missed it. As this API is genneric, it should handle column privileges as well. I will address it. > On Dec. 7, 2018, 7:40 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Lines 3943 (patched) > > <https://reviews.apache.org/r/69353/diff/2/?file=2112512#file2112512line3943> > > > > You don't fetch users of that privilege. Do you want to return that? If > > the caller does not want it, it can be dropped. Or let a input indicating > > if we want to get users as well I will address it. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69353/#review211119 ----------------------------------------------------------- On Dec. 7, 2018, 12:05 a.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69353/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2018, 12:05 a.m.) > > > Review request for sentry and Sergio Pena. > > > Bugs: SENTRY-2454 > https://issues.apache.org/jira/browse/SENTRY-2454 > > > Repository: sentry > > > Description > ------- > > New sentry API should be implemented to fetch the privileges granted to > authorizables and it's children. authorizables include database, tables, > columns and URI's. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > e2d6c85ac6b285e286c12f7eec669b841cf76e9d > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java > e48eea377b842475f72b6fab4567a82c8fd93098 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > ca8c41610d3dcd12b267579c3d3cbe5b7ba7b208 > > > Diff: https://reviews.apache.org/r/69353/diff/2/ > > > Testing > ------- > > Added new unit tests to test the API added. > > > Thanks, > > kalyan kumar kalvagadda > >
