----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69536/#review211171 -----------------------------------------------------------
can you add test case to cover the issue you want to fix? There is no path info, but if the table name is changed, the privilege is moved to table of new name? - Na Li On Dec. 10, 2018, 2:21 a.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69536/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2018, 2:21 a.m.) > > > Review request for sentry, Na Li and Sergio Pena. > > > Repository: sentry > > > Description > ------- > > SENTRY-2471: Table rename should sync Sentry privilege even without location > information > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java > 7b7d0e1eb7ea1f17dea622e51ccc557e0b76fbff > > > Diff: https://reviews.apache.org/r/69536/diff/2/ > > > Testing > ------- > > existing unit tests > > > Thanks, > > Hao Hao > >