----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69596/#review211647 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryKerberosContext.java Lines 40 (patched) <https://reviews.apache.org/r/69596/#comment297051> The only thing we were checking every second was whether or not to shut the thead down. That's no longer necessary with the renewerFuture.cancel() call on line 140. The 1s while loop was primarily a delay mechanism to wait until the next refresh interval before renewing the Kerberos ticket. That's now being handled by having a periodic executor instead. The 30s interval came from my talks with Brian Towles. He says the refresh interval for Kerberos tickets is usually in the order of hours, so it's not something we have to check constantly. I have it checking every 30s just in case the refresh interval has changed and we need to renew the ticket earlier than expected. But given the length of time Kerberos tickets are active, that should be sufficient to keep on top of the renewal. - Haley Reeve On Dec. 19, 2018, 5:25 p.m., Haley Reeve wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69596/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2018, 5:25 p.m.) > > > Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, Na Li, and > Sergio Pena. > > > Bugs: SENTRY-1797 > https://issues.apache.org/jira/browse/SENTRY-1797 > > > Repository: sentry > > > Description > ------- > > The SentryKerberosContext class tries to simulate periodic executor using > while loop with a sleep in the run() method. Instead it should use periodic > executor. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryKerberosContext.java > efb8ae6 > > > Diff: https://reviews.apache.org/r/69596/diff/1/ > > > Testing > ------- > > Ran unit tests. > > > Thanks, > > Haley Reeve > >
