> On Sept. 5, 2018, 8:27 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java > > Lines 74 (patched) > > <https://reviews.apache.org/r/68622/diff/1/?file=2082214#file2082214line74> > > > > we should seperate the logic for path update from perm update. They can > > be independent.
They need not be because sentry namenode plugin requets for both paths and permissions in a single request and sentry responds back with pahs and permissions in the same response back. > On Sept. 5, 2018, 8:27 p.m., Na Li wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java > > Lines 75 (patched) > > <https://reviews.apache.org/r/68622/diff/1/?file=2082214#file2082214line75> > > > > this line is the same as line 74. Why do you duplicate it? There was a typo. Good find. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68622/#review208371 ----------------------------------------------------------- On Jan. 24, 2019, 6:38 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68622/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2019, 6:38 p.m.) > > > Review request for sentry and Arjun Mishra. > > > Bugs: SENTRY-2287 > https://issues.apache.org/jira/browse/SENTRY-2287 > > > Repository: sentry > > > Description > ------- > > Currently there is no way to confirm that HDFS ACL synchronization is > complete when snapshot is initiated. We need to identify that and log in > console and log file as well. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > 08b16a4df3ea9126f21248365d6096fcdb83f21e > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathDeltaRetriever.java > 81c614a345c122e067ec0a19b8f75766390b2ad4 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PathImageRetriever.java > 3532ef33dde8b119ab095861381fa52fa5520f4c > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermDeltaRetriever.java > 8d6713acd61f99940f72c4985098dfeabb9fc832 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/PermImageRetriever.java > 443434127b14fadaeb27717ad2370dcdc10ca70c > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceProcessor.java > 0cd405b54ee2b4bf788dffb1ac606362614f6efe > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/PathUpdaterState.java > PRE-CREATION > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/PermUpdaterState.java > PRE-CREATION > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryStateBank.java > 2afe919c31b0c5f495d54c6448593abad38eddc2 > > > Diff: https://reviews.apache.org/r/68622/diff/2/ > > > Testing > ------- > > > Thanks, > > kalyan kumar kalvagadda > >
