----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69702/#review212291 -----------------------------------------------------------
Fix it, then Ship it! Please consider the cosmetic comments added. You can address them if you agree and commit the change. sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBindingBase.java Line 158 (original), 162 (patched) <https://reviews.apache.org/r/69702/#comment298042> Why is thie removed? sentry-binding/sentry-binding-hive-conf/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java Lines 113 (patched) <https://reviews.apache.org/r/69702/#comment298195> Don't you think, senry.metastore.read.authorization.enabled is better? sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBindingBase.java Lines 142 (patched) <https://reviews.apache.org/r/69702/#comment298197> variable name, readAuthorizationEnabled would be clear, sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBindingBase.java Line 158 (original), 163 (patched) <https://reviews.apache.org/r/69702/#comment298196> Why is change needed? sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBindingBase.java Lines 212 (patched) <https://reviews.apache.org/r/69702/#comment298198> How about authorizeDatabaseRead? sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBindingBase.java Lines 217 (patched) <https://reviews.apache.org/r/69702/#comment298199> How about authorizeTableRead? - kalyan kumar kalvagadda On Jan. 29, 2019, 4:15 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69702/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2019, 4:15 p.m.) > > > Review request for sentry, Arjun Mishra and kalyan kumar kalvagadda. > > > Bugs: sentry-2483 > https://issues.apache.org/jira/browse/sentry-2483 > > > Repository: sentry > > > Description > ------- > > Add READ_DATABASE and READ_TABLE events support to provide read authorization > to HMS. > > This is based on changed made by Sergio at > https://reviews.apache.org/r/69620/, and add code to fix unstable e2e tests > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-conf/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java > 9efd612 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBindingBase.java > 328d2b5 > sentry-tests/sentry-tests-hive/pom.xml 74777bb > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 8bf486e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java > 7d41348 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java > f14cbb6 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestAuthorizingObjectStore.java > 3c28fd0 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java > f8f304f > > > Diff: https://reviews.apache.org/r/69702/diff/7/ > > > Testing > ------- > > add new e2e tests for READ_DATABASE and READ_TABLE at HMS > > > Thanks, > > Na Li > >
