----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69875/#review212500 -----------------------------------------------------------
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Line 206 (original), 207 (patched) <https://reviews.apache.org/r/69875/#comment298276> Can you add a log message here? sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Line 222 (original), 223 (patched) <https://reviews.apache.org/r/69875/#comment298277> We need a DEBUG level log here sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Line 236 (original), 237 (patched) <https://reviews.apache.org/r/69875/#comment298278> We need a DEBUG level log here sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Line 256 (original), 257 (patched) <https://reviews.apache.org/r/69875/#comment298279> Same here sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Line 358 (original), 359 (patched) <https://reviews.apache.org/r/69875/#comment298280> Can you add log here? sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Line 387 (original), 388 (patched) <https://reviews.apache.org/r/69875/#comment298281> Can you add log here? sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Line 412 (original), 413 (patched) <https://reviews.apache.org/r/69875/#comment298282> Log here? sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Line 425 (original), 426 (patched) <https://reviews.apache.org/r/69875/#comment298283> Log here? sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Line 435 (original), 436 (patched) <https://reviews.apache.org/r/69875/#comment298284> Same here? sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Lines 454 (patched) <https://reviews.apache.org/r/69875/#comment298285> Can we change the convention to method name then other information? It'll be easy to track. Thoughts? sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Lines 464 (patched) <https://reviews.apache.org/r/69875/#comment298286> Same as above method name + arguments - followed by message sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Line 468 (original), 472 (patched) <https://reviews.apache.org/r/69875/#comment298288> Log here? sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Lines 476 (patched) <https://reviews.apache.org/r/69875/#comment298287> This should be logged before the method sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Line 481 (original), 487 (patched) <https://reviews.apache.org/r/69875/#comment298289> Log here? sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Lines 502 (patched) <https://reviews.apache.org/r/69875/#comment298290> Same here? sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Line 511 (original), 518 (patched) <https://reviews.apache.org/r/69875/#comment298291> Log here? sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Line 526 (original), 535 (patched) <https://reviews.apache.org/r/69875/#comment298292> Log here? sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Line 695 (original), 704 (patched) <https://reviews.apache.org/r/69875/#comment298293> I prefer the old way of logging. Logs the messag that is called. Its easier to track sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java Line 725 (original) <https://reviews.apache.org/r/69875/#comment298294> I prefer the old way of logging - Arjun Mishra On Jan. 31, 2019, 4:46 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69875/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2019, 4:46 p.m.) > > > Review request for sentry, Arjun Mishra, Haley Reeve, and Na Li. > > > Bugs: SENTRY-2205 > https://issues.apache.org/jira/browse/SENTRY-2205 > > > Repository: sentry > > > Description > ------- > > Logging will help us identify below > 1. Track the updates from Sentry > 2. What the path update is? > 3. What the perm update is? > 4. How the path change is effecting the exizting cache and what is the result > of the update? > 5. How the perm change is effecting the exizting cache and what is the result > of the update? > 6. Changes to the path tree stored as part of the cache. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java > 97a04d9eb5a1e0c5feb97b038b8fc0edec9b0d38 > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/Updateable.java > bbf3f13e44ca3ee6ecb1d635abb9048942b26ac3 > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPaths.java > c967f4e2ee0a811e04362aef452b1cfddfd973f3 > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java > 9dae03562aff82574dcda5339df415193655d5a2 > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java > 5726c0e834e6e5ad47f47f3337d9317ee1366955 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceClientDefaultImpl.java > 9115697088cab8fd1732086963c7c3f982069380 > > > Diff: https://reviews.apache.org/r/69875/diff/1/ > > > Testing > ------- > > As there is no functiuonal change I have not added any tests. I made sure > that existing tests pass. > > > Thanks, > > kalyan kumar kalvagadda > >
