----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69573/#review212596 -----------------------------------------------------------
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java Line 136 (original), 136 (patched) <https://reviews.apache.org/r/69573/#comment298420> Can you change the comment to include the situation that "seqNum > curSeqNum +1", and under what situation, it may happen? You don't need to wait for my addition approval before commiting the change - Na Li On Dec. 17, 2018, 5:07 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69573/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2018, 5:07 p.m.) > > > Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, Na Li, and > Sergio Pena. > > > Bugs: SENTRY-2477 > https://issues.apache.org/jira/browse/SENTRY-2477 > > > Repository: sentry > > > Description > ------- > > If NN seq number and latest sentry sequence number is larger than 1 we need > to request a full update > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > 08b16a4df > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestDBUpdateForwarder.java > f86ce6f83 > > > Diff: https://reviews.apache.org/r/69573/diff/1/ > > > Testing > ------- > > $ mvn -f sentry-hdfs/sentry-hdfs-service/pom.xml test > -Dtest=TestDBUpdateForwarder > > > Thanks, > > Arjun Mishra > >
