-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70008/#review212959
-----------------------------------------------------------




sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/authz/TestMetastoreAuthzObjectFilter.java
Lines 83-102 (original)
<https://reviews.apache.org/r/70008/#comment298835>

    I prefer having the older code. Reusing the privileges defined in 
MetastoreAuthzObjectFilter might not be good option. Here is why
    
    Currently test code has defined LIST_DATABASES_PRIVILEGES and 
LIST_TABLES_PRIVILEGES seperately. Some time later some one change the 
priviliege definations in MetastoreAuthzObjectFilter tests would fail because 
of they are defined seperatly. It's ont way to find something changed. 
    
    If test code used he same definations there will be chance that issues will 
not be exposed by tests.
    
    I understand multiple tests has the same code. You can normalize that part 
if you want but resuing the definations in MetastoreAuthzObjectFilter might not 
be good idea.


- kalyan kumar kalvagadda


On Feb. 19, 2019, 9:56 p.m., Na Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70008/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2019, 9:56 p.m.)
> 
> 
> Review request for sentry, Arjun Mishra, Haley Reeve, and kalyan kumar 
> kalvagadda.
> 
> 
> Bugs: SENTRY-2500
>     https://issues.apache.org/jira/browse/SENTRY-2500
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> CREATE privilege is added for listing tables. So create on server can get 
> list of table names
> 
> 
> Diffs
> -----
> 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/MetastoreAuthzObjectFilter.java
>  178780e 
>   
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/authz/TestMetastoreAuthzObjectFilter.java
>  3ca89be 
>   
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/metastore/TestSentryMetaStoreFilterHook.java
>  1f7148b 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java
>  d63957a 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/StaticUserGroup.java
>  8306e95 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestShowMetadataPrivileges.java
>  88e697b 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java
>  f1600c5 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java
>  6327f16 
> 
> 
> Diff: https://reviews.apache.org/r/70008/diff/4/
> 
> 
> Testing
> -------
> 
> existing tests for metastore, and add two new tests for reading database and 
> tables.
> 
> 
> Thanks,
> 
> Na Li
> 
>

Reply via email to