-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70068/
-----------------------------------------------------------

Review request for sentry and kalyan kumar kalvagadda.


Bugs: sentry-2503
    https://issues.apache.org/jira/browse/sentry-2503


Repository: sentry


Description
-------

When granting all privilege on a table from impala-shell, this privilege cannot 
be revoked from hiove beeline.

When granting all privilege on a table from hive beeline, this privilege cannot 
be revoked from impala-shell.

The reason is that impala uses "ALL" to represent all privilege, and hive uses 
"*". So getting privilege to drop it does not properly.

The solution is to find all equivalent privileges from input, and drop them.


Diffs
-----

  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/QueryParamBuilder.java
 240120c 
  
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
 1d97ff6 
  
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
 38b4c87 


Diff: https://reviews.apache.org/r/70068/diff/1/


Testing
-------

add new tests and all old tests in TestSentryStore pass


Thanks,

Na Li

Reply via email to