----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72704/#review221367 -----------------------------------------------------------
Ship it! Change looks good, you need to understand that this reduces the chance of having dplicate entries but does not guarentee it. - kalyan kumar kalvagadda On July 23, 2020, 8:55 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72704/ > ----------------------------------------------------------- > > (Updated July 23, 2020, 8:55 p.m.) > > > Review request for sentry and kalyan kumar kalvagadda. > > > Bugs: sentry-2422 > https://issues.apache.org/jira/browse/sentry-2422 > > > Repository: sentry > > > Description > ------- > > before saving notification ID, check to make sure only save it if it is > larger than the values of existing entries. We only track and use > max(Notification ID). So no need to persist duplicated values. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 980c8ad > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > fd14963 > > > Diff: https://reviews.apache.org/r/72704/diff/1/ > > > Testing > ------- > > add new unit tests, and they pass > > > Thanks, > > Na Li > >
