----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14014/#review25969 -----------------------------------------------------------
If this the behavior we want to keep, this patch looks good. One minor nit. Please refer to my comment on the JIRA abt the behavior. sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/Roles.java <https://reviews.apache.org/r/14014/#comment50677> equalsIgnoreCase to be safe? - Shreepadma Venugopalan On Sept. 6, 2013, 6:39 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14014/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2013, 6:39 p.m.) > > > Review request for sentry and Shreepadma Venugopalan. > > > Bugs: SENTRY-1 > https://issues.apache.org/jira/browse/SENTRY-1 > > > Repository: sentry > > > Description > ------- > > To validate permissions for "use default", Hive bindings send Database.ALL to > the policy engine. We are not handling the db wildchar correctly during the > database role lookups. > The patch corrects that part. > > > Diffs > ----- > > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/Roles.java > 556be01 > > sentry-provider/sentry-provider-file/src/test/java/org/apache/sentry/provider/file/AbstractTestSimplePolicyEngine.java > bfa2d68 > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestPerDBConfiguration.java > b0523ab > > Diff: https://reviews.apache.org/r/14014/diff/ > > > Testing > ------- > > Added new unit and e2e test cases. Full test run passes with the patch. > > > Thanks, > > Prasad Mujumdar > >
