-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14165/
-----------------------------------------------------------
Review request for sentry and Shreepadma Venugopalan.
Bugs: SENTRY-4
https://issues.apache.org/jira/browse/SENTRY-4
Repository: sentry
Description
-------
SENTRY-4: Rename Configuration properties that mention hive but are sentry
related
As discussed in the JIRA, does the following:
0) add new sentry.* properties, as discussed in SENTRY-14
1) remove deprecation code around hive.access.* properties
2) add deprecation code around hive.sentry.* properties
3) warn about deprecated configs only if they actually end up being used
I'm a bit unsure of spacing (how many spaces is a tab? I used two in most
places -- perhaps something to add to the how to contribute page?)
Diffs
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java
5190ba6
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java
bfd58fa
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindings.java
20d4e8f
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzConf.java
de59546
sentry-binding/sentry-binding-hive/src/test/resources/access-site.xml 1936c21
sentry-binding/sentry-binding-hive/src/test/resources/sentry-site.xml beef40d
sentry-tests/src/test/resources/access-site.xml e4de05a
sentry-tests/src/test/resources/sentry-site.xml de0c9cf
Diff: https://reviews.apache.org/r/14165/diff/
Testing
-------
Ran the unit tests and they were successful:
mvn test -Pdownload-hadoop
Thanks,
Gregory Chanan