----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14244/ -----------------------------------------------------------
(Updated Sept. 20, 2013, 6:24 p.m.) Review request for sentry, Brock Noland, Prasad Mujumdar, and Shreepadma Venugopalan. Changes ------- Unit tests which depend on PolicyFile have been modified to accommodate the change. Repository: sentry Description ------- * All the tests are changed to use the below static user:group mapping (except TestUserManagement) admin1 = admin user1_1 = user_group1 user1_2 = user_group1 user2_1 = user_group2 user3_1 = user_group3 user4_1 = user_group4 * By default tests would use above static mapping. * New mappings can be added in the future when needed. * If static mapping is not feasible for a particular test case, on the fly user:mapping can be used for just this test case. * Test cases in TestUserManagement change the mapping per test, hence this test case is using per test mapping. But we can explore if this can also be using a static mapping with a follow up Jira. * For per DB policy files, as [users] section should not be used, policyFile.setUserSection(false) can be used. Diffs (updated) ----- pom.xml c4aaf07 sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java fafe79b sentry-provider/sentry-provider-file/src/test/java/org/apache/sentry/provider/file/TestPolicyParsingNegative.java 7285806 sentry-provider/sentry-provider-file/src/test/java/org/apache/sentry/provider/file/TestSimplePolicyEngineDFS.java 656a0fa sentry-tests/src/test/java/org/apache/sentry/tests/e2e/AbstractTestWithHiveServer.java d4060d3 sentry-tests/src/test/java/org/apache/sentry/tests/e2e/AbstractTestWithStaticConfiguration.java 40232c8 sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestCrossDbOps.java c822863 sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestEndToEnd.java c45dfbc sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestExportImportPrivileges.java 22fe430 sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestMetadataObjectRetrieval.java 24684f2 sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestMetadataPermissions.java f3d493f sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestMovingToProduction.java c7b5e31 sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestPerDBConfiguration.java 8d520fc sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestPerDatabasePolicyFile.java 8c0fb71 sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestPrivilegeAtTransform.java 53f295d sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestPrivilegesAtDatabaseScope.java 69bfddc sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestPrivilegesAtFunctionScope.java 25746c1 sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestPrivilegesAtTableScope.java ed4509e sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestRuntimeMetadataRetrieval.java b9f71a9 sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestSandboxOps.java 70c460e sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestSentryOnFailureHookLoading.java 43469c5 sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestServerConfiguration.java 2c7ed7e sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestUriPermissions.java 51ced04 sentry-tests/src/test/java/org/apache/sentry/tests/e2e/TestUserManagement.java ed9fe36 Diff: https://reviews.apache.org/r/14244/diff/ Testing ------- All tests pass Thanks, Sravya Tirukkovalur
