Agreed. I have personally always preferred patches generated via git format-patch. That way it's easier to attribute the commit to the contributor because their name shows in the actual git commit. The committer who committed the patch only shows up in the comment which I think is more fair.
FWIW, Apache Bigtop, another project I am involved with recommends git format-patch as well: https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute On Wed, Oct 2, 2013 at 12:25 PM, Brock Noland <[email protected]> wrote: > As was pointed out here: > > > https://issues.apache.org/jira/browse/SENTRY-17?focusedCommentId=13784320&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13784320 > > the how to contribute wiki asks for patches with --no-prefix. Since we are > using git, why are we asking for this? Additionally this makes patches > which add files invalid so we should probably remove this request from the > wiki. > > Brock >
