----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14665/#review27063 -----------------------------------------------------------
Mostly LGTM, just two questions below. sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/conf/SolrAuthzConf.java <https://reviews.apache.org/r/14665/#comment52692> This should just be: return get(varName, AuthzConfVars.getDefault(varName)); right? sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/binding/solr/TestSolrAuthzBinding.java <https://reviews.apache.org/r/14665/#comment52690> I think you mean assertTrue()? IIRC Java assertions are disabled by default. sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/ResourceAuthorizationProvider.java <https://reviews.apache.org/r/14665/#comment52691> Good catch - Brock Noland On Oct. 16, 2013, 1:43 a.m., Gregory Chanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14665/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2013, 1:43 a.m.) > > > Review request for sentry, Brock Noland and Shreepadma Venugopalan. > > > Bugs: SENTRY-36 > https://issues.apache.org/jira/browse/SENTRY-36 > > > Repository: sentry > > > Description > ------- > > A simple implementation of the binding layer for solr, providing index-level > authorization. > > NOTE: this does not include the Solr CustomComponent that will call this code > from a solr context, as described in SENTRY-36. That code is still to be > written. This is just the code that the custom component will call to > inteface with Sentry. > > > Diffs > ----- > > pom.xml a713c41 > sentry-binding/pom.xml af2efa4 > sentry-binding/sentry-binding-solr/pom.xml PRE-CREATION > > sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SentrySolrAuthorizationException.java > PRE-CREATION > > sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java > PRE-CREATION > > sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/conf/SolrAuthzConf.java > PRE-CREATION > > sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/binding/solr/TestSolrAuthzBinding.java > PRE-CREATION > sentry-binding/sentry-binding-solr/src/test/resources/log4j.properties > PRE-CREATION > sentry-binding/sentry-binding-solr/src/test/resources/sentry-site.xml > PRE-CREATION > > sentry-binding/sentry-binding-solr/src/test/resources/test-authz-provider.ini > PRE-CREATION > sentry-dist/pom.xml 895b03c > sentry-dist/src/main/assembly/src.xml 91f5696 > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/ResourceAuthorizationProvider.java > 4e12b70 > > Diff: https://reviews.apache.org/r/14665/diff/ > > > Testing > ------- > > Ran the unit tests successfully; I haven't run the e2e tests but this > shouldn't affect them. > > > Thanks, > > Gregory Chanan > >
