----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15335/ -----------------------------------------------------------
(Updated Nov. 8, 2013, 9:05 p.m.) Review request for sentry, Brock Noland and Shreepadma Venugopalan. Changes ------- Updated for Brock's comments. Repository: sentry Description ------- Today, the SolrAuthzBinding uses the SimpleFileProviderBackend, which ends up creating a configuration via: new Configuration(); the issue with this is this might not be the Configuration we want – for example, in a secure setup, it may not have all the authentication/authorization properties necessary to connect to hdfs to read the sentry .ini file. I'm not sure exactly how this works in hive, but it may be because hive has the relevant core-site.xml, hdfs-site.xml in its classpath, whereas in solr, this is uncommon. Solr does have a way to specify hdfs configs already via the HdfsDirectoryFactory and HdfsUtils -- I just reuse this and add a constructor to SimpleFileProviderBackend. Diffs (updated) ----- pom.xml 997b1f4 sentry-binding/sentry-binding-solr/pom.xml 4ed491a sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java 94f9c57 sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/SimpleFileProviderBackend.java 5e0aa66 Diff: https://reviews.apache.org/r/15335/diff/ Testing ------- Ran the non-e2e unit tests. Also ran the code with a real solr cluster to verify that the correct Configuration was loaded and we could read a .ini file from secure HDFS. Thanks, Gregory Chanan
