----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15547/#review28917 -----------------------------------------------------------
Ship it! LGTM! sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java <https://reviews.apache.org/r/15547/#comment55981> trailing ws - Shreepadma Venugopalan On Nov. 14, 2013, 9:55 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15547/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2013, 9:55 p.m.) > > > Review request for sentry and Shreepadma Venugopalan. > > > Bugs: SENTRY-63 > https://issues.apache.org/jira/browse/SENTRY-63 > > > Repository: sentry > > > Description > ------- > > Hive compiler generates UDF entity type for UDF used in query. Sentry > currently doens't handle UDFs as authorizable type. It's only used for > enforcing the whitelist. The authorization hoook shouldn't try to process the > UDF types further. We do that for buildin UDFs but not for the temp UDFs > created by user. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > 5395c50 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java > 62e206a > > Diff: https://reviews.apache.org/r/15547/diff/ > > > Testing > ------- > > Updated the TestPrevilegesAtFunctionScope() to cover UDF execution scenarios. > > At this point, there's some build issue on the maser branch and I am not able > to test the patch on trunk. Verify with older release. will retest after the > build issue is resolved. > > > Thanks, > > Prasad Mujumdar > >
