> On March 24, 2014, 8:20 p.m., Brock Noland wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java, > > line 214 > > <https://reviews.apache.org/r/19560/diff/2/?file=534082#file534082line214> > > > > I think this one needs to be URI as well?
yes, sorry missed that one. - Prasad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19560/#review38353 ----------------------------------------------------------- On March 24, 2014, 8:49 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19560/ > ----------------------------------------------------------- > > (Updated March 24, 2014, 8:49 p.m.) > > > Review request for sentry, Brock Noland and Shreepadma Venugopalan. > > > Bugs: SENTRY-137 > https://issues.apache.org/jira/browse/SENTRY-137 > > > Repository: sentry > > > Description > ------- > > Put privilege scopes in SentryConstants [SERVER, DB, TABLE, URI] > Ensure the SentryPolicyStoreClient client is setting this properties. > Validate this property when on the grant/revoke privilege commands in > SentryStore > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > 464569c > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 9562783 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 1b36690 > > Diff: https://reviews.apache.org/r/19560/diff/ > > > Testing > ------- > > sentry-provider-db tests pass with the patch. > > > Thanks, > > Prasad Mujumdar > >
