> On March 27, 2014, 7:13 a.m., Prasad Mujumdar wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java, > > line 65 > > <https://reviews.apache.org/r/19711/diff/2/?file=538215#file538215line65> > > > > Perhaps should be moved to HiveAuthzConf. It would be good to keep all > > the sentry specific hive configs in same module. > > Also should this be called hive.sentry.active.role.set ?
I wasn't seeing this is a config option. I only created it so we can persist the active role set across queries. However, I think we should move it to the config, just not advertise it's configurable until we get some requests. - Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19711/#review38704 ----------------------------------------------------------- On March 27, 2014, 3:49 a.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19711/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 3:49 a.m.) > > > Review request for sentry, Prasad Mujumdar and Shreepadma Venugopalan. > > > Bugs: SENTRY-149 > https://issues.apache.org/jira/browse/SENTRY-149 > > > Repository: sentry > > > Description > ------- > > Implements SET ROLE NONE and SET ROLE some_role. SET ROLE ALL will come in a > follow-on. > > > Diffs > ----- > > pom.xml 5bda553 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java > 70b05b6 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > 0b83299 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > 252d93b > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java > eddf3ae > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/AccessConstants.java > 4be391f > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestDatabaseProvider.java > b8163b3 > > Diff: https://reviews.apache.org/r/19711/diff/ > > > Testing > ------- > > Modified test passes. > > > Thanks, > > Brock Noland > >
