Committed it to 1.3.0 release branch. Thanks Brock! P.S: I just realized that my commit message is not consistent with the usual format. Will adhere to the format going forward, sorry about it.
On Fri, Mar 28, 2014 at 6:51 PM, Brock Noland <[email protected]> wrote: > Yes if we have a patch, I think it makes sense to put it in. > > > On Fri, Mar 28, 2014 at 6:43 PM, Sravya Tirukkovalur <[email protected] > >wrote: > > > Apologies for late reply on this thread. > > > > As it looks like we will anyways need another RC, can we try to push this > > fix into 1.3.0 release branch? I am trying out a fix right now, will > upload > > a patch if it works. > > > > > > On Wed, Mar 26, 2014 at 10:00 AM, karthik ramachandran < > > [email protected]> wrote: > > > > > Thanks, that's what I figured. I'll go ahead and cut the RC. > > > > > > By the way, the current HEAD does build cleanly on all three platforms. > > > > > > > > > On Wed, Mar 26, 2014 at 9:22 AM, Brock Noland <[email protected]> > > wrote: > > > > > > > I don't think we should Mac a supported platform today. FWIW there > are > > > > fixes in 1.4.0 for Mac so the next release should work on a mac. > > > > > > > > > > > > On Wed, Mar 26, 2014 at 9:18 AM, karthik ramachandran < > > > > [email protected]> wrote: > > > > > > > > > All, > > > > > > > > > > Correction- the 1.3.0 branch does build cleanly on CentOS[6.4], > > > > > Ubunutu[13.04] with Java 1.7.0_51. However it does not build on OS > > > > > X[10.9.2] with Java 1.7.0_51. > > > > > > > > > > > > > > > Under OS X[10.9.2] / Java 1.7.0_51, the Hive tests issues the > > > following > > > > > error: > > > > > > > > > > java.sql.SQLException: Error while compiling statement: FAILED: > > > > > SemanticException No valid privileges > > > > > > > > > > at org.apache.hive.jdbc.Utils.verifySuccess(Utils.java:167) > > > > > > > > > > at org.apache.hive.jdbc.Utils.verifySuccessWithInfo(Utils.java:155) > > > > > > > > > > at > org.apache.hive.jdbc.HiveStatement.execute(HiveStatement.java:210) > > > > > > > > > > at > > > > > > > > > > > > > > > > > > > > org.apache.sentry.tests.e2e.hive.TestPrivilegesAtFunctionScope.testFuncPrivileges1(TestPrivilegesAtFunctionScope.java:104) > > > > > What is the verdict of the mob? Cut the RC? > > > > > > > > > > Thanks, > > > > > Karthik > > > > > > > > > > > > > > > > > > > > On Mon, Mar 24, 2014 at 5:06 PM, karthik ramachandran < > > > > > [email protected]> wrote: > > > > > > > > > > > Hi all, > > > > > > > > > > > > Per our previous discussion[1], I cherry picked SENTRY-124 onto > the > > > > 1.3.0 > > > > > > branch and pushed that up. However, a large number of tests > > related > > > to > > > > > > Hive currently fail. > > > > > > > > > > > > It appears that SENTRY-130 (sha: > > > > > bd511cdb284d8e8048bc85a5ea171c09535fe485) > > > > > > fixes those errors. However, that commit doesn't cleanly > > cherry-pick > > > > > onto > > > > > > the 1.3.0 branch. > > > > > > > > > > > > Could someone please take a look at the 1.3.0 branch and let me > > know > > > > how > > > > > > to proceed? I am assuming we don't want to cut an RC until we get > > all > > > > the > > > > > > tests to pass? > > > > > > > > > > > > > > > > > > 1. > > > > > > > > > > > > > > > > > > > > > http://mail-archives.apache.org/mod_mbox/sentry-dev/201403.mbox/%3CCAO8U8NF8uSKjVb3_ab%2BnMuhuOu05o%2BwD2RPzT96tE_hZikPfXQ%40mail.gmail.com%3E > > > > > > > > > > > > Thanks, > > > > > > > > > > > > Karthik > > > > > > -- > > > > > > Karthik Ramachandran > > > > > > Mobile: 412-606-8981 > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Karthik Ramachandran > > > > > Mobile: 412-606-8981 > > > > > > > > > > > > > > > > > > > > > -- > > > Karthik Ramachandran > > > Mobile: 412-606-8981 > > > > > > > > > > > -- > > Sravya Tirukkovalur > > > -- Sravya Tirukkovalur
