On Fri, Apr 4, 2014 at 11:15 AM, Jarek Jarcec Cecho <[email protected]> wrote:
> Hi David,
> thank you very much for your feedback, greatly appreciated! You've raised 
> couple of really good points.
>
> The rat issues is interesting - indeed we are not setting the 
> excludeSubProjects to false but at the same time rat is checking all 
> subprojects. I've just tried to put incorrectly licensed file into one of the 
> sub modules and it has been correctly detected, so I'm assuming that this one 
> should be covered.
>

The bigger issue isn't rat configuration, it's how do we answer the
question of why so many files don't have license headers.

> Looking at the rest of the feedback it seems that nothing is a release 
> blocker per say, so I'm wondering if you are fine with us moving forward with 
> the release?
>

My vote is just a single vote, nothing says you have to stop. -1's
aren't vetoes in release votes. I personally want to get to the point
where I can vote +1 but am not there yet.

--David

Reply via email to