-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19980/#review40343
-----------------------------------------------------------
Ship it!
LGTM! Nice work!!
One nit, the second line of the createShowRolesTask method is indented quite a
bit. Can you clean this up and attach the patch to the ticket for commit?
{noformat}
+ @Override
+ public Task<? extends Serializable> createShowRolesTask(ASTNode ast,
+ Path resFile,
HashSet<ReadEntity> inputs, HashSet<WriteEntity> outputs) throws
SemanticException {
{noformat}
- Brock Noland
On April 15, 2014, 1:34 a.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19980/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 1:34 a.m.)
>
>
> Review request for sentry, Brock Noland, Prasad Mujumdar, Shreepadma
> Venugopalan, and Xuefu Zhang.
>
>
> Bugs: sentry-165
> https://issues.apache.org/jira/browse/sentry-165
>
>
> Repository: sentry
>
>
> Description
> -------
>
> HIVE-6793 added a new function, createShowRolesTask() to the
> HiveAuthorizationTaskFactory interface. I have basically mimicked the
> upstream implementation here:
> https://issues.apache.org/jira/secure/attachment/12637896/HIVE-6793.patch
>
> But the only thing I am not sure about is this part:
> new RoleDDLDesc(null, null, RoleDDLDesc.RoleOperation.SHOW_ROLES, null);
> principalType, principalName, roleName = null.
>
> Looks like we should be getting these values from the ast as in here?
> https://github.com/apache/incubator-sentry/blob/master/sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java#L85
>
>
> Diffs
> -----
>
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java
> de0e460a982dc72f7f2dff3f53ea80cbc6945475
>
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java
> a61f609821cb143972d0333571df9837405740aa
>
> Diff: https://reviews.apache.org/r/19980/diff/
>
>
> Testing
> -------
>
> Compile and existing tests pass.
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>
