> On April 22, 2014, 3:51 p.m., Lenni Kuff wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java, > > line 81 > > <https://reviews.apache.org/r/20543/diff/1/?file=564105#file564105line81> > > > > Should you make the group name mixed case?
Actually, now if I think back, we should probably allow case sensitive group names. I believe unix group names are case sensitive. I guess LDAP is case sensitive as well. - Sravya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20543/#review41029 ----------------------------------------------------------- On April 22, 2014, 1:28 a.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20543/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 1:28 a.m.) > > > Review request for sentry, Lenni Kuff and Prasad Mujumdar. > > > Bugs: sentry-177 > https://issues.apache.org/jira/browse/sentry-177 > > > Repository: sentry > > > Description > ------- > > Sentry service was treating role names and group names in a case sensitive > fashion. Fixed it and added new unit tests. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > ac6c6f73426e5960505ad6dd4e7b6e3ab84f2aeb > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 40b94604a8afa40184422a98e93a759c1d9cdc1d > > Diff: https://reviews.apache.org/r/20543/diff/ > > > Testing > ------- > > New tests and existing tests pass. > > > Thanks, > > Sravya Tirukkovalur > >
