Did the following checks: - md5 and sha1 match up - git tag (checksum) matches artifact - compile and tests ran successfully
As I mentioned previously, the copyright notice in NOTICE.txt is out of date. That doesn't seem like it needs to be a blocker; I'm not a copyright expert but it doesn't seem any worse to release that NOTICE.txt than to have it as is in the source. So, I'm +1. Greg On Mon, Apr 28, 2014 at 4:01 PM, Sravya Tirukkovalur <[email protected]>wrote: > Sorry, hit the send button too soon. > > +1 from me. > > > On Mon, Apr 28, 2014 at 3:57 PM, Sravya Tirukkovalur <[email protected] > >wrote: > > > Thanks for the quick turn around Kathik! > > > > Following look good: > > - md5 and sha1 of the src tar ball match with the one published > > - contents of the tar and tag are the same > > - Compiles fine. > > - No issues with bundling hadoop and other jars. > > > > > > > > > > > > > > On Mon, Apr 28, 2014 at 2:57 PM, karthik ramachandran < > > [email protected]> wrote: > > > >> Sorry, one of the links was incorrect in the previous message. > >> > >> > >> > >> ======= > >> > >> This is a release of Apache Sentry, version 1.3.0-incubating. > >> > >> It fixes the following issues: http://s.apache.org/iCB > >> > >> Source files : > http://people.apache.org/~kramachandran/sentry-1.3.0-rc3/ > >> > >> Tag to be voted on (release-1.3.0-rc3 / SHA > >> 31c8aca46c060685bd5a01f7706e2adab78a20d8): > >> > >> > https://git-wip-us.apache.org/repos/asf/incubator-sentry/repo?p=incubator-sentry.git;a=log;h=refs/tags/release-1.3.0-rc > >> < > >> > https://git-wip-us.apache.org/repos/asf/incubator-sentry/repo?p=incubator-sentry.git;a=log;h=refs/tags/release-1.3.0-rc3 > >> >3 > >> > >> > >> > >> Sentry's KEYS containing the PGP key we used to sign the > >> release:https://people.apache.org/keys/group/sentry.asc > >> > >> Note that this is a source only release and we are voting on the > >> source (release-1.3.0-rc3 / SHA: > >> 31c8aca46c060685bd5a01f7706e2adab78a20d8). > >> > >> > >> Vote will be open for 72 hours. > >> > >> [ ] +1 approve > >> [ ] +0 no opinion > >> [ ] -1 disapprove (and reason why) > >> > >> > >> Thanks, > >> Karthik > >> > >> > >> > >> On Mon, Apr 28, 2014 at 2:15 PM, karthik ramachandran < > >> [email protected]> wrote: > >> > >> > > >> > This is a release of Apache Sentry, version 1.3.0-incubating. > >> > > >> > It fixes the following issues: http://s.apache.org/iCB > >> > > >> > Source files : > >> http://people.apache.org/~kramachandran/sentry-1.3.0-rc3/ < > >> http://people.apache.org/~kramachandran/sentry-1.3.0-rc2/> > >> > > >> > Tag to be voted on (release-1.3.0-rc3 / SHA > >> 31c8aca46c060685bd5a01f7706e2adab78a20d8): > >> > https://git-wip-us.apache.org/repos/asf/incubator-sentry/repo?p=incubator-sentry.git;a=log;h=refs/tags/release-1.3.0-rc > < > >> > https://git-wip-us.apache.org/repos/asf/incubator-sentry/repo?p=incubator-sentry.git;a=log;h=refs/tags/release-1.3.0-rc3 > >> >3 > >> > > >> > > >> > > >> > Sentry's KEYS containing the PGP key we used to sign the release: > >> https://people.apache.org/keys/group/sentry.asc > >> > > >> > Note that this is a source only release and we are voting on the > source > >> (release-1.3.0-rc3 / SHA: 31c8aca46c060685bd5a01f7706e2adab78a20d8). > >> > > >> > > >> > Vote will be open for 72 hours. > >> > > >> > [ ] +1 approve > >> > [ ] +0 no opinion > >> > [ ] -1 disapprove (and reason why) > >> > > >> > > >> > Thanks, > >> > Karthik > >> > > >> > > >> > >> > >> -- > >> Karthik Ramachandran > >> Mobile: 412-606-8981 > >> > > > > > > > > -- > > Sravya Tirukkovalur > > > > > > -- > Sravya Tirukkovalur >
