> On April 29, 2014, 2:09 a.m., Vamsee Yarlagadda wrote: > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestBase.java, > > line 767 > > <https://reviews.apache.org/r/20796/diff/1/?file=569690#file569690line767> > > > > Should we log this rather than printing it on console?
Sounds like a good idea to me. - Gregory ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20796/#review41673 ----------------------------------------------------------- On April 28, 2014, 9:48 p.m., Gregory Chanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20796/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 9:48 p.m.) > > > Review request for sentry and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > Converts the solr e2e tests to use MiniSolrCloudCluster rather than the > lucene test hierarchy. > > This requires upgrading to Solr 4.8.0. > > > Diffs > ----- > > pom.xml c52f7ad > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestBase.java > bc36967 > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestCollAdminCoreOperations.java > 8509497 > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestQueryOperations.java > 6658560 > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestUpdateOperations.java > d4855da > > Diff: https://reviews.apache.org/r/20796/diff/ > > > Testing > ------- > > Ran the solr related unit and e2e tests. > > > Thanks, > > Gregory Chanan > >
