> On April 29, 2014, 2:23 a.m., Vamsee Yarlagadda wrote: > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java, > > line 275 > > <https://reviews.apache.org/r/20805/diff/2/?file=569820#file569820line275> > > > > Should we also add "bogusUser" to see if it returns "only all groups" > > documents?
I don't think so. If bogusUser doesn't exist, he can't query the collection, because index-level auth is on. It may be interesting to test if index-level auth is off, but that's outside the scope of this JIRA. - Gregory ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20805/#review41674 ----------------------------------------------------------- On April 28, 2014, 10:42 p.m., Gregory Chanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20805/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 10:42 p.m.) > > > Review request for sentry and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > Adds some solr e2e tests for doc-level security. NOTE: this patch requires > SENTRY-159. > > The test are as follows: > 1) simple e2e test that checks that queries return expected results > 2) support for an "all" groups token > 3) not susceptible to (trivial) injection attempts > > > Diffs > ----- > > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/AbstractSolrSentryTestBase.java > bc36967 > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java > PRE-CREATION > > sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/schema.xml > 2aa68dd > > sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/solrconfig-doclevel.xml > PRE-CREATION > > sentry-tests/sentry-tests-solr/src/test/resources/solr/sentry/test-authz-provider.ini > 3e02699 > > Diff: https://reviews.apache.org/r/20805/diff/ > > > Testing > ------- > > Ran the new e2e tests. > > > Thanks, > > Gregory Chanan > >
