----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20447/#review41783 -----------------------------------------------------------
pom.xml <https://reviews.apache.org/r/20447/#comment75376> I understand the point of not packaging hadoop, hive jar's. But some third party jar's like bonecp, datanucleus-api-jdo, datanucleus-rdbms, mockito-all may not exist in the end system. And the mvn scope "provided" will assume these jar's will be provided by the container at run time. So, we need to make sure that these lib's be installed as dependency during the Sentry RPM installation or the Sentry might fail to work on systems with just Solr installed. (Hive has dependency on the above third party jar's so there will no issues on hive end) Or, we can end up bundling these exclusive third party jar's with Sentry to avoid confusion. - Vamsee Yarlagadda On April 29, 2014, 10:10 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20447/ > ----------------------------------------------------------- > > (Updated April 29, 2014, 10:10 p.m.) > > > Review request for sentry, Brock Noland, Mark Grover, and Prasad Mujumdar. > > > Bugs: SENTRY-174 > https://issues.apache.org/jira/browse/SENTRY-174 > > > Repository: sentry > > > Description > ------- > > Sentry should not package hadoop, hive and other third party jars. > > > Diffs > ----- > > pom.xml c52f7adb89269166666cc695ec54f253181b6188 > sentry-dist/src/main/assembly/bin.xml > 7c7c4a93318c80696dc1944fa403bd1a422f2eac > > Diff: https://reviews.apache.org/r/20447/diff/ > > > Testing > ------- > > All existing tests pass. > > > Thanks, > > Sravya Tirukkovalur > >
