----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21045/#review42192 -----------------------------------------------------------
Ship it! LGTM. - Vamsee Yarlagadda On May 3, 2014, 12:04 a.m., Gregory Chanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21045/ > ----------------------------------------------------------- > > (Updated May 3, 2014, 12:04 a.m.) > > > Review request for sentry, Sravya Tirukkovalur and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > This is necessary for supporting switching the authorization tokens in solr > document-level security from groups to roles. > > The function is on the ProviderBackend, but I didn't implement it for the > SimpleDBProviderBackend. It seems like work is still being done on hashing > out what this would look like in SENTRY-184. If people are okay with this > approach, I'll file a JIRA to implement it on the SimpleDBProviderBackend > once the work there is settled. > > > Diffs > ----- > > > sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java > 9a6e623 > > sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/binding/solr/TestSolrAuthzBinding.java > e2e3403 > > sentry-binding/sentry-binding-solr/src/test/resources/test-authz-provider.ini > f8100e0 > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ProviderBackend.java > 26c4878 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SimpleDBProviderBackend.java > b068aca > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/SimpleFileProviderBackend.java > e7f69ac > > Diff: https://reviews.apache.org/r/21045/diff/ > > > Testing > ------- > > Ran the unit and e2e tests. > > > Thanks, > > Gregory Chanan > >
