----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21468/#review43110 -----------------------------------------------------------
Mostly looks good to me. A minor comment below. sentry-provider/sentry-provider-cache/src/main/java/org/apache/sentry/provider/cache/SimpleCacheProviderBackend.java <https://reviews.apache.org/r/21468/#comment77124> I dont see this conf and resourcePath being used anywhere, might as well get rid of it? In which case we can also get rid of hadoop-common dependency. - Sravya Tirukkovalur On May 14, 2014, 11:29 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21468/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 11:29 p.m.) > > > Review request for sentry, Lenni Kuff and Sravya Tirukkovalur. > > > Bugs: SENTRY-156 > https://issues.apache.org/jira/browse/SENTRY-156 > > > Repository: sentry > > > Description > ------- > > The patch implements a simple cache based policy provider that reads the > privilege metadata from a cache interface. > > > Diffs > ----- > > sentry-provider/pom.xml 9bec058 > sentry-provider/sentry-provider-cache/pom.xml PRE-CREATION > > sentry-provider/sentry-provider-cache/src/main/java/org/apache/sentry/provider/cache/PrivilegeCache.java > PRE-CREATION > > sentry-provider/sentry-provider-cache/src/main/java/org/apache/sentry/provider/cache/SimpleCacheProviderBackend.java > PRE-CREATION > > sentry-provider/sentry-provider-cache/src/test/java/org/apache/sentry/provider/cache/PrivilegeCacheTestImpl.java > PRE-CREATION > > sentry-provider/sentry-provider-cache/src/test/java/org/apache/sentry/provider/cache/TestCacheProvider.java > PRE-CREATION > > sentry-provider/sentry-provider-cache/src/test/resources/test-authz-provider-local-group-mapping.ini > PRE-CREATION > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ProviderBackendContext.java > f45d23d > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java > 22f1b08 > > Diff: https://reviews.apache.org/r/21468/diff/ > > > Testing > ------- > > Added new unit test cases for the provider. > > > Thanks, > > Prasad Mujumdar > >
