----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21496/#review43290 -----------------------------------------------------------
Ship it! Looks fine. Thanks for addressing the comments. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestDatabaseProvider.java <https://reviews.apache.org/r/21496/#comment77380> I think you already fixed this as SENTRY-204. - Prasad Mujumdar On May 16, 2014, 11:02 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21496/ > ----------------------------------------------------------- > > (Updated May 16, 2014, 11:02 p.m.) > > > Review request for sentry and Prasad Mujumdar. > > > Bugs: SENTRY-150 > https://issues.apache.org/jira/browse/SENTRY-150 > > > Repository: sentry > > > Description > ------- > > Support following commands in hive binding using Sentry service and the > expected output format: > SHOW ROLES > | role | > > SHOW GRANT ROLE roleName > | database | table | partition | column | principal_name | > principal_type | privilege | grant_option | grant_time | grantor | > > SHOW ROLE GRANT GROUP groupName > | role | grant_option | grant_time | grantor | > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java > 2776eaec97dee25c15a526cd0d70b6a637993b4f > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > 2e7a9d9043ae0a31d7d9c5f57dac92209feea24e > sentry-tests/sentry-tests-hive/pom.xml > 0005a534876320ff0aededf56a45833e0a6a1d41 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestDatabaseProvider.java > 51bb62325100de597a23f8cbe3197b06f0eefea0 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/AbstractHiveServer.java > be6eafc226b122345523ccbcf2434f46264edffb > > Diff: https://reviews.apache.org/r/21496/diff/ > > > Testing > ------- > > Added end to end tests which exercise the above commands. > > > Thanks, > > Sravya Tirukkovalur > >
