-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21596/
-----------------------------------------------------------

(Updated May 17, 2014, 12:12 a.m.)


Review request for sentry, Jarek Cecho and Sravya Tirukkovalur.


Changes
-------

Handle the driver name property similar to connection URL and username 
properties.


Bugs: SENTRY-213
    https://issues.apache.org/jira/browse/SENTRY-213


Repository: sentry


Description
-------

The sentry service expects the datanucleus and JDO config properties to be 
prefixed with 'sentry.'. The schema tool reads the JDBC connection driver from 
the same configuration. It's looking for javax.jdo prefix. This in not 
consistent with sentry store service.
The patch is to use the same config name.


Diffs (updated)
-----

  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
 09af86d 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentrySchemaTool.java
 1ba1345 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java
 2a5553c 
  
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentrySchemaTool.java
 17755e3 

Diff: https://reviews.apache.org/r/21596/diff/


Testing
-------

Updated sentry schema tool tests.


Thanks,

Prasad Mujumdar

Reply via email to