----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21651/#review43409 -----------------------------------------------------------
Thanks for the patch Arun, it mostly looks good to me. A minor comment below. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java <https://reviews.apache.org/r/21651/#comment77510> Doesn't this delete mprivilege even if there is another role having this privilege? - Sravya Tirukkovalur On May 19, 2014, 6:56 p.m., Arun Suresh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21651/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 6:56 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-214 > https://issues.apache.org/jira/browse/SENTRY-214 > > > Repository: sentry > > > Description > ------- > > Sentry Service does not allow the same Privilege to be associated to multiple > Roles > > Steps to recreate : > 1) Create role1 > 2) Create role2 > 3) Grant 'role1' a Privilege(ALL) to a Table t1, Db d1, server S1 > 4) the 'listPrivilegesByRoleName' API applied to 'role1' returns a set of > size 1 > 5) Grant 'role2' the same Privilege as role 1.. a Privilege(ALL) to a Table > t1, Db d1, server S1 > 6) the 'listPrivilegesByRoleName' API applied to 'role2' returns a set of > size 0 > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 325dedf > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java > 1e4ed17 > > Diff: https://reviews.apache.org/r/21651/diff/ > > > Testing > ------- > > > Thanks, > > Arun Suresh > >
