> On May 19, 2014, 9:33 p.m., Prasad Mujumdar wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentrySchemaTool.java, > > line 198 > > <https://reviews.apache.org/r/21661/diff/1/?file=584679#file584679line198> > > > > Since we are removing the term metastore, can be change this one to > > Sentry store as well ?
Thanks for the review Prasad! Changed it in the updated patch. - Sravya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21661/#review43422 ----------------------------------------------------------- On May 19, 2014, 10:06 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21661/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 10:06 p.m.) > > > Review request for sentry and Prasad Mujumdar. > > > Bugs: SENTRY-218 > https://issues.apache.org/jira/browse/SENTRY-218 > > > Repository: sentry > > > Description > ------- > > Attaching a patch for: > Driver defaults to org.apache.derby.jdbc.EmbeddedDriver > User name/password defaults to "Sentry" > Throw appropriate error messages > > Also did some cleanup: > * Remove HiveMetaException > * Handle conf paramaters reading early in the constructor > * Print allowable dbtypes > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java > 0b5d1ca3e1a6457e1423b0f17922858fa95dd91d > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentrySchemaTool.java > 79977cf51f82d2c74fab467c833d0420e88a444b > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentrySchemaTool.java > ce09f624ee18555483b2cacd7ea432a17d1736cb > > Diff: https://reviews.apache.org/r/21661/diff/ > > > Testing > ------- > > Changed schema tool tests to use default parameters. > > > Thanks, > > Sravya Tirukkovalur > >
