----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21655/#review43411 -----------------------------------------------------------
Ship it! LGTM, some minor comments below. sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java <https://reviews.apache.org/r/21655/#comment77513> Nit: Spacing sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java <https://reviews.apache.org/r/21655/#comment77588> Nit: Trailing white space sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbEndToEnd.java <https://reviews.apache.org/r/21655/#comment77613> This is already done in createContext() (Line #101) sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbEndToEnd.java <https://reviews.apache.org/r/21655/#comment77614> Does this test case intentionally test only granting of uri privileges, but not authorization of them? - Sravya Tirukkovalur On May 19, 2014, 8:01 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21655/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 8:01 p.m.) > > > Review request for sentry and Sravya Tirukkovalur. > > > Bugs: SENTRY-217 > https://issues.apache.org/jira/browse/SENTRY-217 > > > Repository: sentry > > > Description > ------- > > Support INSERT and URI privilege in DB provider > Extended basic test framework for DB provider testing > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/SentryHiveConstants.java > db14b6c > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java > b6f39ad > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > 9ca11ae > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 325dedf > sentry-tests/sentry-tests-hive/pom.xml 1d0e169 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbEndToEnd.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/21655/diff/ > > > Testing > ------- > > Added test new tests > > > Thanks, > > Prasad Mujumdar > >
