----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21715/#review43635 -----------------------------------------------------------
Ship it! sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestDatabaseProvider.java <https://reviews.apache.org/r/21715/#comment77915> Not related to this patch, but I am wondering if we should catch setting active role to something that's not granted to the user. It's not a security loophole though, since we first extract the allowed roles and then further filter using active roles. Perhaps we should log a followup ticket to track it. - Prasad Mujumdar On May 20, 2014, 5:31 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21715/ > ----------------------------------------------------------- > > (Updated May 20, 2014, 5:31 p.m.) > > > Review request for sentry and Prasad Mujumdar. > > > Bugs: SENTRY-216 > https://issues.apache.org/jira/browse/SENTRY-216 > > > Repository: sentry > > > Description > ------- > > Support SHOW CURRENT ROLES > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java > b6f39ad7c4c15b377e7ea55e28ec7bbe19653d18 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java > 7a561ef0f4572490b35fc3408bd18fb17ce5f21c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestDatabaseProvider.java > 176aceeeed33302e5f0dc7144b673eb792fb3e3d > > Diff: https://reviews.apache.org/r/21715/diff/ > > > Testing > ------- > > Added end to end hive test. Also added meta data tests for other "show" test > cases. > > > Thanks, > > Sravya Tirukkovalur > >
