----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22015/#review44311 -----------------------------------------------------------
Ship it! Looks fine to me. - Prasad Mujumdar On May 29, 2014, 7:53 a.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22015/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 7:53 a.m.) > > > Review request for sentry and Prasad Mujumdar. > > > Bugs: SENTRY-235 > https://issues.apache.org/jira/browse/SENTRY-235 > > > Repository: sentry > > > Description > ------- > > Refactored AbstractTestWithDbProvider to allow sentry.provider > Refactored TestDatabaseProvider and TestDbEndToEnd to use the refactored base > class. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerWithoutKerberos.java > d3e2ad3bfcf4414bd0d9006fec092824f67eb3d7 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java > 5b655f39b7ccc891c4108dec15dc52601ef2fb80 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbEndToEnd.java > eb9f91b04d49a6210524c9d19114736be642c368 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestDatabaseProvider.java > fd28789093ae68e18482677d7a133f021d318c90 > > Diff: https://reviews.apache.org/r/22015/diff/ > > > Testing > ------- > > Ran tests > > > Thanks, > > Sravya Tirukkovalur > >
