----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22062/#review44313 -----------------------------------------------------------
Ship it! LGTM - Prasad Mujumdar On May 29, 2014, 9:43 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22062/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 9:43 p.m.) > > > Review request for sentry and Prasad Mujumdar. > > > Bugs: SENTRY-202 > https://issues.apache.org/jira/browse/SENTRY-202 > > > Repository: sentry > > > Description > ------- > > SENTRY-176 removed the handling of writing policy file to HDFS logic from > PolicyFile. Hence we need to do it explicitly when running tests on real > cluster. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 2b36d80c898eb9f7993e7ee28d0e6dd934f129da > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java > 7ef3975d8c1c2d19bb48ed42d39d42388cecf3f5 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestEndToEnd.java > 26a92741fd9d1f784e263dfdfef520e895c9a0dc > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestExportImportPrivileges.java > 435572128f9ec8ab238def9fdb3711e7624dc48c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMetadataObjectRetrieval.java > 667ebb515c6a6b61b1d56d46dd9850ce42a0886c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMetadataPermissions.java > d5e2f1aa44c80a2c01484065963d91faee14b80f > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMovingToProduction.java > a53bffed5e6649040e0946fd2dbab434501b20e5 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDatabasePolicyFile.java > 5c7c7d161933b8adefc3dcb8fcb2d49f7bd66fd4 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegeAtTransform.java > 93a370490c3b8b8c310d8170f3baa7327a473531 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtDatabaseScope.java > 416411c45aa763482b58bf5c34a637c3c9a22b3f > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java > 976c3e9eb1baeb8156452a805c5c8bf73b4ea742 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtTableScope.java > 56ed06a0cfbb0cb258bec8a2b8665885fbb96662 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestRuntimeMetadataRetrieval.java > 9e9aec3538e7bc489e3c557803fd5b48007dc90c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java > d9330cb205f44b925fcd90e325991108643e0a0e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java > e1cf0732b30cd6e0ca6114f28b39551dc385daeb > > Diff: https://reviews.apache.org/r/22062/diff/ > > > Testing > ------- > > All tests pass > > > Thanks, > > Sravya Tirukkovalur > >
