> On May 30, 2014, 6:14 p.m., Arun Suresh wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java, > > line 202 > > <https://reviews.apache.org/r/21995/diff/2/?file=599550#file599550line202> > > > > As per current logic, we will be doing 1 RPC per "authorizable > > Hierachy".. not an authorizable object.. > > > > I agree, Join of multiple tables.. i.e sending multiple hierarchies > > would require us to create a new Hierarchy Datastructure (a list of list > > perhaps)... as a simple list will not suffice.. > > > > But Id prefer working on it in follow-up JIRAs if you don't mind.. > > > > I have included some integration tests in TestSEntryIntegration.. I can > > add somemore if required.. do let me know if I missed some usecases..
Ah, ok. I was under the impression that each authorizable corresponds to a heirarchy like "server=server1->db=default". So, I think we are good here. Thanks for the clarification! - Sravya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21995/#review44395 ----------------------------------------------------------- On May 30, 2014, 1:27 a.m., Arun Suresh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21995/ > ----------------------------------------------------------- > > (Updated May 30, 2014, 1:27 a.m.) > > > Review request for sentry, Jarek Cecho, Prasad Mujumdar, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Patch for SENTRY-157(https://issues.apache.org/jira/browse/SENTRY-157) > > To support push-down of Authorizable Hierarchy > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java > f1e6247 > > sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/PolicyEngine.java > c378a38 > > sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/SimpleDBPolicyEngine.java > a95ef7b > > sentry-policy/sentry-policy-db/src/test/java/org/apache/sentry/policy/db/AbstractTestSimplePolicyEngine.java > 4625d6f > > sentry-policy/sentry-policy-db/src/test/java/org/apache/sentry/policy/db/TestPolicyParsingNegative.java > e88ae32 > > sentry-policy/sentry-policy-db/src/test/java/org/apache/sentry/policy/db/TestSimpleDBPolicyEngineDFS.java > 08f84a3 > > sentry-policy/sentry-policy-search/src/main/java/org/apache/sentry/policy/search/SimpleSearchPolicyEngine.java > 8adcb6f > > sentry-provider/sentry-provider-cache/src/main/java/org/apache/sentry/provider/cache/SimpleCacheProviderBackend.java > 1b0aba6 > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ProviderBackend.java > a175245 > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java > e1e7f4a > > sentry-provider/sentry-provider-common/src/test/java/org/apache/sentry/provider/common/TestGetGroupMapping.java > ece740b > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SimpleDBProviderBackend.java > 54c1d6d > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java > 952ee78 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 7e2323c > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > 2aac409 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > f92c78a > > sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift > b4281c7 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 67b05e6 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java > 56dcaf9 > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/SimpleFileProviderBackend.java > 6e8f02f > > Diff: https://reviews.apache.org/r/21995/diff/ > > > Testing > ------- > > > Thanks, > > Arun Suresh > >
