----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22213/#review44683 -----------------------------------------------------------
Ship it! Ship It! - Sravya Tirukkovalur On June 3, 2014, 9:02 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22213/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 9:02 p.m.) > > > Review request for sentry and Sravya Tirukkovalur. > > > Bugs: SENTRY-243 > https://issues.apache.org/jira/browse/SENTRY-243 > > > Repository: sentry > > > Description > ------- > > The statement operation type passed to onFailure hook is extracted from the > operation type stored in Hive's per-session thread. That is not a reliable > place to look up the operation during the process execution. We need to store > the operation type in the grant revoke task during the compilation. Also the > failure hook should be fired for AccessDenied exception rather than all > exceptions. > > The patch saves the operation type in the Task when it created during > compilation. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java > df9b0db > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > a362363 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java > 41a31e8 > > Diff: https://reviews.apache.org/r/22213/diff/ > > > Testing > ------- > > Updated the test case to add multiple DDLs before the auth statements. > > > Thanks, > > Prasad Mujumdar > >
