> On June 3, 2014, 5:04 a.m., Prasad Mujumdar wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java, > > line 156 > > <https://reviews.apache.org/r/22101/diff/1/?file=600278#file600278line156> > > > > It might be helpful to add the error message in the log. The catch > > block can rethrow the exception.
Makes sense, updating the patch. - Sravya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22101/#review44599 ----------------------------------------------------------- On May 31, 2014, 12:58 a.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22101/ > ----------------------------------------------------------- > > (Updated May 31, 2014, 12:58 a.m.) > > > Review request for sentry, Brock Noland and Prasad Mujumdar. > > > Bugs: SENTRY-207 > https://issues.apache.org/jira/browse/SENTRY-207 > > > Repository: sentry > > > Description > ------- > > Changed SentryService to implement Callable to be able to throw exceptions. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > a0ac224bf03f36e0650af6ee784cc6608b5764e7 > > Diff: https://reviews.apache.org/r/22101/diff/ > > > Testing > ------- > > Ran sentry service without initializing schema, and the error code was 1. > > > Thanks, > > Sravya Tirukkovalur > >
