----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22225/#review44909 -----------------------------------------------------------
Few notes: sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java <https://reviews.apache.org/r/22225/#comment79492> Would you mind changing this to Set<TSentryGroup> tSentryGroups = new HashSet<TSentryGroup>(); To make it JDK6 compatible? sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java <https://reviews.apache.org/r/22225/#comment79493> This assert seems to be failing for me as the value is the priviledge set is: server=server1->URI=file:///var/folders/dt/9zm44z9s6bjfxbrm4v36lzdc0000gp/T/1401860678102-0/data/kv1.dat->action=ALL (the difference is capital "URI") Jarcec - Jarek Cecho On June 4, 2014, 8:47 a.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22225/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 8:47 a.m.) > > > Review request for sentry, Arun Suresh and Prasad Mujumdar. > > > Bugs: SENTRY-246 and SENTRY-250 > https://issues.apache.org/jira/browse/SENTRY-246 > https://issues.apache.org/jira/browse/SENTRY-250 > > > Repository: sentry > > > Description > ------- > > Did a case insensitive filtering for URIs. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > ff656aaa754070957ad73549ca1facfa5a433952 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 524eea3725a190cce9bbb3781fa5b98fd9aa1831 > > Diff: https://reviews.apache.org/r/22225/diff/ > > > Testing > ------- > > Tests pass. > > > Thanks, > > Sravya Tirukkovalur > >
