> On June 6, 2014, 7:58 p.m., Jarek Cecho wrote: > > Couple of high level notes.
The reverts are due to the branch being out of sync with master. I will close this one and different review request. Addressed the feedback, except a followup ticket for the kerberos related ToDo. will log ticket later. > On June 6, 2014, 7:58 p.m., Jarek Cecho wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBinding.java, > > lines 274-276 > > <https://reviews.apache.org/r/22301/diff/1/?file=604693#file604693line274> > > > > Isn't this equivalent with: > > > > return InvalidOperationException(e.getMessage(), e) Unfortunately, this is a this exception is defined in Metastore thrift IDL, and hence comming from the generated java code. It has just one constructor which is why the workaround. - Prasad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22301/#review44954 ----------------------------------------------------------- On June 6, 2014, 8:12 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22301/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 8:12 a.m.) > > > Review request for sentry, Arun Suresh, Brock Noland, and Sravya Tirukkovalur. > > > Bugs: SENTRY-259 > https://issues.apache.org/jira/browse/SENTRY-259 > > > Repository: sentry > > > Description > ------- > > - Basic metastore binding via pre-even listener hooks. Uses the same > privilege model as hive. > - Test framework support for starting a metastore server > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java > 54c9a41 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java > 7b7bf8e > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBinding.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/PolicyProviderForTest.java > 79ca387 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java > 84223a9 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java > 41a31e8 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 835e547 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/Context.java > 39d411e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestSentryOnFailureHookLoading.java > cae270b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/MiniDFS.java > 184c066 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java > 19ff6cf > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/InternalMetastoreServer.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/22301/diff/ > > > Testing > ------- > > basic e2e tests with metastore server. Additional metastore test cases will > be added via a separate patch. > > > Thanks, > > Prasad Mujumdar > >
