----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22358/#review45045 -----------------------------------------------------------
Ship it! Ship It! - Brock Noland On June 8, 2014, 9:22 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22358/ > ----------------------------------------------------------- > > (Updated June 8, 2014, 9:22 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-166 > https://issues.apache.org/jira/browse/SENTRY-166 > > > Repository: sentry > > > Description > ------- > > I've fixed the problem by setting a limit to 2 on splitting the key-value > pair. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java > efc5671 > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/KeyValue.java > 622736a > > sentry-provider/sentry-provider-file/src/test/java/org/apache/sentry/provider/file/TestKeyValue.java > 1d8c9ae > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java > dd45a31 > > Diff: https://reviews.apache.org/r/22358/diff/ > > > Testing > ------- > > Added multiple tests to ensure that this functionality will work end to end. > I've also rerun all Hive E2E tests to ensure that we won't regress (which > seems to be the case). > > > Thanks, > > Jarek Cecho > >
