-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22340/
-----------------------------------------------------------
(Updated June 9, 2014, 2:13 a.m.)
Review request for sentry, Brock Noland, Jarek Cecho, and Sravya Tirukkovalur.
Changes
-------
Updates per review feedback -
- Fixed Minor typos, comments etc.
- Moved the metastore specific test APIs to a new base class. The new e2e test
is now extending this metastore specific class
Bugs: SENTRY-259
https://issues.apache.org/jira/browse/SENTRY-259
Repository: sentry
Description
-------
- Basic metastore binding via pre-even listener hooks. Uses the same privilege
model as hive. Required authorizable lists are created and the hive binding is
invoked with the corresponding hive operation type. The rest of the auth is
then handled by the Sentry.
- Test framework support for starting a metastore server
Diffs (updated)
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java
63484a8
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java
7b7bf8e
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBinding.java
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java
f9928df
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java
66d6eef
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java
5d7428a
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/PolicyProviderForTest.java
8e8db72
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java
a8ce2a2
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java
b6bb09c
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/Context.java
d8f5256
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestSentryOnFailureHookLoading.java
cae270b
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/MiniDFS.java
184c066
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java
19ff6cf
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/InternalMetastoreServer.java
PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java
PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java
PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/resources/core-site.xml PRE-CREATION
Diff: https://reviews.apache.org/r/22340/diff/
Testing
-------
Added new test with various DB and Table opeartions. Additional testing effort
is tracked by a different jira.
Thanks,
Prasad Mujumdar